misc: rfkill: rephrase gpio warning messages
Preetham Chandru [Mon, 4 Jun 2012 08:29:31 +0000 (13:29 +0530)]
The current BCM4329 rfkill driver assumes usage of 2 GPIOs
known as RST and SHUTDOWN and the driver makes a particular
GPIO mandatory. Some of the platforms does not define both
GPIOs, instead a single either RST/SHUTDOWN GPIO is used to
setup the chip.
Hence print a less alarming message if gpio is not found.

Bug 975333
Signed-off-by: Preetham Chandru r <pchandru@nvidia.com>

Change-Id: I229844d9d5dfc94ea00bb086d1091ac41bf97b99
Reviewed-on: http://git-master/r/106158
Tested-by: Preetham Chandru <pchandru@nvidia.com>
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Kiran Adduri <kadduri@nvidia.com>
Reviewed-by: Rakesh Goyal <rgoyal@nvidia.com>
Reviewed-by: Bharat Nihalani <bnihalani@nvidia.com>
GVS: Gerrit_Virtual_Submit

drivers/misc/bcm4329_rfkill.c

index cf56768..9dc33fd 100644 (file)
@@ -111,7 +111,9 @@ static int bcm4329_rfkill_probe(struct platform_device *pdev)
                ret = gpio_request(bcm4329_rfkill->gpio_reset,
                                                "bcm4329_nreset_gpio");
        } else {
-               pr_warn("%s : can't find reset gpio.\n", __func__);
+               pr_warn("%s : can't find reset gpio. "
+                       "reset gpio may not be defined for "
+                       "this platform \n", __func__);
                bcm4329_rfkill->gpio_reset = 0;
        }
 
@@ -123,7 +125,9 @@ static int bcm4329_rfkill_probe(struct platform_device *pdev)
                ret = gpio_request(bcm4329_rfkill->gpio_shutdown,
                                                "bcm4329_nshutdown_gpio");
        } else {
-               pr_warn("%s : can't find shutdown gpio.\n", __func__);
+               pr_warn("%s : can't find shutdown gpio "
+                       "shutdown gpio may not be defined for "
+                       "this platform \n", __func__);
                bcm4329_rfkill->gpio_shutdown = 0;
        }