dma-buf: Return error instead of using a goto statement when possible
Laurent Pinchart [Thu, 26 Jan 2012 11:27:24 +0000 (12:27 +0100)]
Remove an error label in dma_buf_attach() that just returns an error
code.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>

drivers/base/dma-buf.c

index 198edd8..97450a5 100644 (file)
@@ -190,7 +190,7 @@ struct dma_buf_attachment *dma_buf_attach(struct dma_buf *dmabuf,
 
        attach = kzalloc(sizeof(struct dma_buf_attachment), GFP_KERNEL);
        if (attach == NULL)
-               goto err_alloc;
+               return ERR_PTR(-ENOMEM);
 
        mutex_lock(&dmabuf->lock);
 
@@ -206,8 +206,6 @@ struct dma_buf_attachment *dma_buf_attach(struct dma_buf *dmabuf,
        mutex_unlock(&dmabuf->lock);
        return attach;
 
-err_alloc:
-       return ERR_PTR(-ENOMEM);
 err_attach:
        kfree(attach);
        mutex_unlock(&dmabuf->lock);