]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
x86, numaq: Make CONFIG_X86_NUMAQ depend on CONFIG_PCI
authorPan, Jacob jun <jacob.jun.pan@intel.com>
Thu, 25 Feb 2010 00:59:55 +0000 (16:59 -0800)
committerH. Peter Anvin <hpa@zytor.com>
Thu, 25 Feb 2010 17:04:19 +0000 (09:04 -0800)
The NUMAQ initialization sets x86_init.pci.init to pci_numaq_init,
which obviously isn't defined if CONFIG_PCI isn't defined.  This
dependency was implicit in the past, because pci_numaq_init was
invoked from arch/x86/pci/legacy.c, which itself was conditioned on
CONFIG_PCI.

I suspect that no NUMA-Q machines without PCI were ever built, so
instead of complicating the code by adding #ifdefs or stub functions,
just disable this bit of the configuration space.

[ hpa: rewrote the checkin comment ]

Signed-off-by: Jacob Pan <jacob.jun.pan@intel.com>
LKML-Reference: <43F901BD926A4E43B106BF17856F0755A321EE1F@orsmsx508.amr.corp.intel.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
arch/x86/Kconfig

index 0ab2dcef7d84eb954ac251a310a5420fed6cacfb..f0322949328eac57f83dd6c6174987dd83ad7ee6 100644 (file)
@@ -425,6 +425,7 @@ config X86_32_NON_STANDARD
 config X86_NUMAQ
        bool "NUMAQ (IBM/Sequent)"
        depends on X86_32_NON_STANDARD
+       depends on PCI
        select NUMA
        select X86_MPPARSE
        ---help---