jsm: IRQ handlers doesn't need to have IRQ_DISABLED enabled
Breno Leitão [Thu, 24 Sep 2009 19:58:22 +0000 (16:58 -0300)]
Currently jsm is showing the following message when loaded:

IRQ 432/JSM: IRQF_DISABLED is not guaranteed on shared IRQs

It's because the request_irq() is called using IRQF_DISABLED
and IRQF_SHARED.
Actually there is no need to use IRQF_DISABLED in this driver.

Signed-off-by: Breno Leitão <leitao@linux.vnet.ibm.com>
Cc: Scott Kilau <scottk@digi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

drivers/serial/jsm/jsm_driver.c

index b3604aa..48326f7 100644 (file)
@@ -123,7 +123,7 @@ static int __devinit jsm_probe_one(struct pci_dev *pdev, const struct pci_device
        }
 
        rc = request_irq(brd->irq, brd->bd_ops->intr,
-                       IRQF_DISABLED|IRQF_SHARED, "JSM", brd);
+                       IRQF_SHARED, "JSM", brd);
        if (rc) {
                printk(KERN_WARNING "Failed to hook IRQ %d\n",brd->irq);
                goto out_iounmap;