asus-wmi: potential NULL dereference in show_call()
Dan Carpenter [Tue, 15 Mar 2011 07:07:37 +0000 (10:07 +0300)]
In the earlier check we assumed that "obj" could be NULL.  I looked at
some of the other places that call evaluate_object() and they check
for NULL as well.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>

drivers/platform/x86/asus-wmi.c

index a038595..efc776c 100644 (file)
@@ -1343,7 +1343,7 @@ static int show_call(struct seq_file *m, void *data)
        else
                seq_printf(m, "%#x(%#x, %#x) = t:%d\n", asus->debug.method_id,
                           asus->debug.dev_id, asus->debug.ctrl_param,
-                          obj->type);
+                          obj ? obj->type : -1);
 
        kfree(obj);