regmap: mmio: convert some error returns to BUG()
Stephen Warren [Fri, 6 Apr 2012 21:17:32 +0000 (15:17 -0600)]
Some of the error conditions detected by regmap_mmio_*() are pure internal
errors, rather than user-/client-triggerable conditions. Convert these to
BUG().

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
(cherry picked from commit 40606dba450830e50420599c52a86cf6ce5c6a14)

Change-Id: Ibf926ca6774e4b3d3dd855d42814065858318628
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Reviewed-on: http://git-master/r/96505
Reviewed-by: Simone Willett <swillett@nvidia.com>
Tested-by: Simone Willett <swillett@nvidia.com>

drivers/base/regmap/regmap-mmio.c

index 1a7b5ee..ffa0e85 100644 (file)
@@ -35,8 +35,8 @@ static int regmap_mmio_gather_write(void *context,
        struct regmap_mmio_context *ctx = context;
        u32 offset;
 
-       if (reg_size != 4)
-               return -EIO;
+       BUG_ON(reg_size != 4);
+
        if (val_size % ctx->val_bytes)
                return -EIO;
 
@@ -60,7 +60,7 @@ static int regmap_mmio_gather_write(void *context,
 #endif
                default:
                        /* Should be caught by regmap_mmio_check_config */
-                       return -EIO;
+                       BUG();
                }
                val_size -= ctx->val_bytes;
                val += ctx->val_bytes;
@@ -72,8 +72,8 @@ static int regmap_mmio_gather_write(void *context,
 
 static int regmap_mmio_write(void *context, const void *data, size_t count)
 {
-       if (count < 4)
-               return -EIO;
+       BUG_ON(count < 4);
+
        return regmap_mmio_gather_write(context, data, 4, data + 4, count - 4);
 }
 
@@ -84,8 +84,8 @@ static int regmap_mmio_read(void *context,
        struct regmap_mmio_context *ctx = context;
        u32 offset;
 
-       if (reg_size != 4)
-               return -EIO;
+       BUG_ON(reg_size != 4);
+
        if (val_size % ctx->val_bytes)
                return -EIO;
 
@@ -109,7 +109,7 @@ static int regmap_mmio_read(void *context,
 #endif
                default:
                        /* Should be caught by regmap_mmio_check_config */
-                       return -EIO;
+                       BUG();
                }
                val_size -= ctx->val_bytes;
                val += ctx->val_bytes;