lib: Fix atomic64_add_unless test
Luca Barbieri [Mon, 1 Mar 2010 18:55:45 +0000 (19:55 +0100)]
atomic64_add_unless must return 1 if it perfomed the add and 0 otherwise.
The test assumed the opposite convention.

Reported-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Luca Barbieri <luca@luca-barbieri.com>
LKML-Reference: <1267469749-11878-2-git-send-email-luca@luca-barbieri.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>

lib/atomic64_test.c

index 58efdab..ee8e6de 100644 (file)
@@ -104,11 +104,11 @@ static __init int test_atomic64(void)
        BUG_ON(v.counter != r);
 
        INIT(v0);
-       BUG_ON(!atomic64_add_unless(&v, one, v0));
+       BUG_ON(atomic64_add_unless(&v, one, v0));
        BUG_ON(v.counter != r);
 
        INIT(v0);
-       BUG_ON(atomic64_add_unless(&v, one, v1));
+       BUG_ON(!atomic64_add_unless(&v, one, v1));
        r += one;
        BUG_ON(v.counter != r);