[NETFILTER]: xt_tcpudp: fix double unregistration in error path
Yuri Gushin [Tue, 27 Jun 2006 10:01:03 +0000 (03:01 -0700)]
"xt_unregister_match(AF_INET, &tcp_matchstruct)" is called twice,
leaving "udp_matchstruct" registered, in case of a failure in the
registration of the udp6 structure.

Signed-off-by: Yuri Gushin <yuri@ecl-labs.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

net/netfilter/xt_tcpudp.c

index 1b61dac..a9a63aa 100644 (file)
@@ -260,7 +260,7 @@ static int __init xt_tcpudp_init(void)
        return ret;
 
 out_unreg_udp:
-       xt_unregister_match(&tcp_matchstruct);
+       xt_unregister_match(&udp_matchstruct);
 out_unreg_tcp6:
        xt_unregister_match(&tcp6_matchstruct);
 out_unreg_tcp: