ftrace: Move record update for normal and modules into a separate function
Steven Rostedt [Tue, 26 Apr 2011 20:11:03 +0000 (16:11 -0400)]
The updating of a function record is moved to a single function. This will allow
us to add specific changes in one location for both modules and kernel
functions.

Later patches will determine if the function record itself needs to be updated
(which enables the mcount caller), or just the ftrace_ops needs the update.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

kernel/trace/ftrace.c

index 9abaaf4..5b758ea 100644 (file)
@@ -1743,6 +1743,15 @@ static int ftrace_match(char *str, char *regex, int len, int type)
        return matched;
 }
 
+static void
+update_record(struct dyn_ftrace *rec, unsigned long flag, int not)
+{
+       if (not)
+               rec->flags &= ~flag;
+       else
+               rec->flags |= flag;
+}
+
 static int
 ftrace_match_record(struct dyn_ftrace *rec, char *regex, int len, int type)
 {
@@ -1772,10 +1781,7 @@ static int ftrace_match_records(char *buff, int len, int enable)
        do_for_each_ftrace_rec(pg, rec) {
 
                if (ftrace_match_record(rec, search, search_len, type)) {
-                       if (not)
-                               rec->flags &= ~flag;
-                       else
-                               rec->flags |= flag;
+                       update_record(rec, flag, not);
                        found = 1;
                }
                /*
@@ -1846,10 +1852,7 @@ static int ftrace_match_module_records(char *buff, char *mod, int enable)
 
                if (ftrace_match_module_record(rec, mod,
                                               search, search_len, type)) {
-                       if (not)
-                               rec->flags &= ~flag;
-                       else
-                               rec->flags |= flag;
+                       update_record(rec, flag, not);
                        found = 1;
                }
                if (enable && (rec->flags & FTRACE_FL_FILTER))