sound: read i_size with i_size_read()
Xiaochen Wang [Fri, 18 Mar 2011 08:29:25 +0000 (16:29 +0800)]
Convert direct read of inode->i_size to using i_size_read().
i_size_read is guaranteed to return a valid value and
its caller does not need to use addtional locking.

Signed-off-by: Xiaochen Wang <wangxiaochen0@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

sound/sound_firmware.c

index 340a0bc..7e96249 100644 (file)
@@ -19,7 +19,7 @@ static int do_mod_firmware_load(const char *fn, char **fp)
                printk(KERN_INFO "Unable to load '%s'.\n", fn);
                return 0;
        }
-       l = filp->f_path.dentry->d_inode->i_size;
+       l = i_size_read(filp->f_path.dentry->d_inode);
        if (l <= 0 || l > 131072)
        {
                printk(KERN_INFO "Invalid firmware '%s'\n", fn);