[media] v4l2 core: return -ENOTTY if an ioctl doesn't exist
Mauro Carvalho Chehab [Wed, 6 Jul 2011 17:08:08 +0000 (14:08 -0300)]
Currently, -EINVAL is used to return either when an IOCTL is not
implemented, or if the ioctl was not implemented.

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

Documentation/DocBook/media/v4l/gen-errors.xml
Documentation/DocBook/media/v4l/v4l2.xml
drivers/media/video/v4l2-ioctl.c

index 7c1980e..5bbf3ce 100644 (file)
               ioctl requests for specific causes.</entry>
       </row>
       <row>
-       <entry>EINVAL or ENOTTY</entry>
-       <entry>The ioctl is not supported by the driver, actually meaning that
-              the required functionality is not available, or the file
-              descriptor is not for a media device. The usage of EINVAL is
-              deprecated and will be fixed on a latter patch.</entry>
-      </row>
-      <row>
         <entry>ENODEV</entry>
        <entry>Device not found or was removed.</entry>
       </row>
        <entry>There's not enough memory to handle the desired operation.</entry>
       </row>
       <row>
+       <entry>ENOTTY</entry>
+       <entry>The ioctl is not supported by the driver, actually meaning that
+              the required functionality is not available, or the file
+              descriptor is not for a media device.</entry>
+      </row>
+      <row>
        <entry>ENOSPC</entry>
        <entry>On USB devices, the stream ioctl's can return this error, meaning
               that this request would overcommit the usb bandwidth reserved
index c5ee398..43386a6 100644 (file)
@@ -132,7 +132,9 @@ applications. -->
        <date>2011-06-27</date>
        <authorinitials>mcc, po</authorinitials>
        <revremark>Documented that VIDIOC_QUERYCAP now returns a per-subsystem version instead of a per-driver one.</revremark>
+       <revremark>Standardize an error code for invalid ioctl.</revremark>
       </revision>
+
       <revision>
        <revnumber>2.6.39</revnumber>
        <date>2011-03-01</date>
index 29f7a7d..002ce13 100644 (file)
@@ -543,12 +543,12 @@ static long __video_do_ioctl(struct file *file,
        struct v4l2_fh *vfh = NULL;
        struct v4l2_format f_copy;
        int use_fh_prio = 0;
-       long ret = -EINVAL;
+       long ret = -ENOTTY;
 
        if (ops == NULL) {
                printk(KERN_WARNING "videodev: \"%s\" has no ioctl_ops.\n",
                                vfd->name);
-               return -EINVAL;
+               return ret;
        }
 
        if ((vfd->debug & V4L2_DEBUG_IOCTL) &&