rt2x00: Fix queue->qid initialization
Ivo van Doorn [Sun, 10 Feb 2008 21:51:41 +0000 (22:51 +0100)]
As Adam Baker reported the queue->qid was not initialized
correctly. The QID_AC_BE was assigned to the RX ring.

This will move the queue initialization into a seperate function
and makes sure that all queues are initialized directly with the
correct qids.

Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

drivers/net/wireless/rt2x00/rt2x00queue.c

index 943afc9..9188323 100644 (file)
@@ -228,6 +228,18 @@ void rt2x00queue_uninitialize(struct rt2x00_dev *rt2x00dev)
        }
 }
 
+static void rt2x00queue_init(struct rt2x00_dev *rt2x00dev,
+                            struct data_queue *queue, enum data_queue_qid qid)
+{
+       spin_lock_init(&queue->lock);
+
+       queue->rt2x00dev = rt2x00dev;
+       queue->qid = qid;
+       queue->aifs = 2;
+       queue->cw_min = 5;
+       queue->cw_max = 10;
+}
+
 int rt2x00queue_allocate(struct rt2x00_dev *rt2x00dev)
 {
        struct data_queue *queue;
@@ -265,24 +277,15 @@ int rt2x00queue_allocate(struct rt2x00_dev *rt2x00dev)
         * TX: cw_max: 2^10 = 1024.
         * BCN & Atim: qid = QID_MGMT
         */
-       qid = QID_AC_BE;
-       queue_for_each(rt2x00dev, queue) {
-               spin_lock_init(&queue->lock);
+       rt2x00queue_init(rt2x00dev, rt2x00dev->rx, QID_RX);
 
-               queue->rt2x00dev = rt2x00dev;
-               queue->qid = qid++;
-               queue->aifs = 2;
-               queue->cw_min = 5;
-               queue->cw_max = 10;
-       }
+       qid = QID_AC_BE;
+       tx_queue_for_each(rt2x00dev, queue)
+               rt2x00queue_init(rt2x00dev, queue, qid++);
 
-       /*
-        * Fix non-TX data qid's
-        */
-       rt2x00dev->rx->qid = QID_RX;
-       rt2x00dev->bcn[0].qid = QID_MGMT;
+       rt2x00queue_init(rt2x00dev, &rt2x00dev->bcn[0], QID_MGMT);
        if (req_atim)
-               rt2x00dev->bcn[1].qid = QID_MGMT;
+               rt2x00queue_init(rt2x00dev, &rt2x00dev->bcn[1], QID_MGMT);
 
        return 0;
 }