perf trace/scripting: Check return val of perl_run()
Tom Zanussi [Tue, 15 Dec 2009 08:53:37 +0000 (02:53 -0600)]
The return value from perl_run() is currently ignored, but it
should be checked and used to exit perf if there are problems
loading the script.

Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
Cc: fweisbec@gmail.com
Cc: rostedt@goodmis.org
LKML-Reference: <1260867220-15699-4-git-send-email-tzanussi@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

tools/perf/util/trace-event-perl.c

index 6f10e76..6d6d76b 100644 (file)
@@ -379,7 +379,11 @@ static int perl_start_script(const char *script, int argc, const char **argv)
                goto error;
        }
 
-       perl_run(my_perl);
+       if (perl_run(my_perl)) {
+               err = -1;
+               goto error;
+       }
+
        if (SvTRUE(ERRSV)) {
                err = -1;
                goto error;