drivers/atm: Use DIV_ROUND_CLOSEST
Julia Lawall [Sat, 1 Aug 2009 22:48:45 +0000 (22:48 +0000)]
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@haskernel@
@@

#include <linux/kernel.h>

@depends on haskernel@
expression x,__divisor;
@@

- (((x) + ((__divisor) / 2)) / (__divisor))
+ DIV_ROUND_CLOSEST(x,__divisor)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>

drivers/atm/horizon.c

index 6b969f8..01ce241 100644 (file)
@@ -641,7 +641,7 @@ static int make_rate (const hrz_dev * dev, u32 c, rounding r,
                                        pre = 1;
                                break;
                        case round_nearest:
-                               pre = (br+(c<<div)/2)/(c<<div);
+                               pre = DIV_ROUND_CLOSEST(br, c<<div);
                                // but p must be non-zero
                                if (!pre)
                                        pre = 1;
@@ -671,7 +671,7 @@ static int make_rate (const hrz_dev * dev, u32 c, rounding r,
                                        pre = DIV_ROUND_UP(br, c<<div);
                                        break;
                                case round_nearest:
-                                       pre = (br+(c<<div)/2)/(c<<div);
+                                       pre = DIV_ROUND_CLOSEST(br, c<<div);
                                        break;
                                default: /* round_up */
                                        pre = br/(c<<div);