perf symbols: Pass the offset to perf_header__read_build_ids()
Arnaldo Carvalho de Melo [Mon, 16 Nov 2009 18:32:41 +0000 (16:32 -0200)]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <1258396365-29217-1-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

tools/perf/util/data_map.c
tools/perf/util/data_map.h
tools/perf/util/header.c

index aacb814..14cb846 100644 (file)
@@ -70,11 +70,10 @@ process_event(event_t *event, unsigned long offset, unsigned long head)
        }
 }
 
-int perf_header__read_build_ids(int input, off_t size)
+int perf_header__read_build_ids(int input, off_t offset, off_t size)
 {
        struct build_id_event bev;
        char filename[PATH_MAX];
-       off_t offset = lseek(input, 0, SEEK_CUR);
        off_t limit = offset + size;
        int err = -1;
 
index 20b4037..ae036ec 100644 (file)
@@ -27,6 +27,6 @@ int mmap_dispatch_perf_file(struct perf_header **pheader,
                            int full_paths,
                            int *cwdlen,
                            char **cwd);
-int perf_header__read_build_ids(int input, off_t file_size);
+int perf_header__read_build_ids(int input, off_t offset, off_t file_size);
 
 #endif
index ebed4f4..ca0d657 100644 (file)
@@ -359,7 +359,7 @@ static void perf_header__adds_read(struct perf_header *self, int fd)
 
                buildid_sec = &feat_sec[idx++];
                lseek(fd, buildid_sec->offset, SEEK_SET);
-               if (perf_header__read_build_ids(fd, buildid_sec->size))
+               if (perf_header__read_build_ids(fd, buildid_sec->offset, buildid_sec->size))
                        pr_debug("failed to read buildids, continuing...\n");
        }