TTY: use tty_standard_install
Jiri Slaby [Mon, 30 Jan 2012 20:14:30 +0000 (21:14 +0100)]
Use the helper in the rest of the tty drivers. This is a simple
replacement.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/isdn/capi/capi.c
drivers/misc/pti.c
drivers/mmc/card/sdio_uart.c
drivers/tty/nozomi.c

index e44933d..94948be 100644 (file)
@@ -1015,14 +1015,11 @@ capinc_tty_install(struct tty_driver *driver, struct tty_struct *tty)
 {
        int idx = tty->index;
        struct capiminor *mp = capiminor_get(idx);
-       int ret = tty_init_termios(tty);
+       int ret = tty_standard_install(driver, tty);
 
-       if (ret == 0) {
-               tty_driver_kref_get(driver);
-               tty->count++;
+       if (ret == 0)
                tty->driver_data = mp;
-               driver->ttys[idx] = tty;
-       } else
+       else
                capiminor_put(mp);
        return ret;
 }
index 0b56e3f..471ff4c 100644 (file)
@@ -481,13 +481,9 @@ static int pti_tty_install(struct tty_driver *driver, struct tty_struct *tty)
 {
        int idx = tty->index;
        struct pti_tty *pti_tty_data;
-       int ret = tty_init_termios(tty);
+       int ret = tty_standard_install(driver, tty);
 
        if (ret == 0) {
-               tty_driver_kref_get(driver);
-               tty->count++;
-               driver->ttys[idx] = tty;
-
                pti_tty_data = kmalloc(sizeof(struct pti_tty), GFP_KERNEL);
                if (pti_tty_data == NULL)
                        return -ENOMEM;
index 2c151e1..bd4a67c 100644 (file)
@@ -750,15 +750,12 @@ static int sdio_uart_install(struct tty_driver *driver, struct tty_struct *tty)
 {
        int idx = tty->index;
        struct sdio_uart_port *port = sdio_uart_port_get(idx);
-       int ret = tty_init_termios(tty);
+       int ret = tty_standard_install(driver, tty);
 
-       if (ret == 0) {
-               tty_driver_kref_get(driver);
-               tty->count++;
+       if (ret == 0)
                /* This is the ref sdio_uart_port get provided */
                tty->driver_data = port;
-               driver->ttys[idx] = tty;
-       } else
+       else
                sdio_uart_port_put(port);
        return ret;
 }
index fd347ff..580da78 100644 (file)
@@ -1602,13 +1602,9 @@ static int ntty_install(struct tty_driver *driver, struct tty_struct *tty)
        int ret;
        if (!port || !dc || dc->state != NOZOMI_STATE_READY)
                return -ENODEV;
-       ret = tty_init_termios(tty);
-       if (ret == 0) {
-               tty_driver_kref_get(driver);
-               tty->count++;
+       ret = tty_standard_install(driver, tty);
+       if (ret == 0)
                tty->driver_data = port;
-               driver->ttys[tty->index] = tty;
-       }
        return ret;
 }