[ALSA] usbaudio - Revert the minimal period size fix patch
Takashi Iwai [Thu, 3 May 2007 10:26:14 +0000 (12:26 +0200)]
The last patch didn't really work (false report).
Although the hardware supports 125us minimum period, the current
usb-audio driver code assumes the 1ms period in many places.
Rollback the change.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>

sound/usb/usbaudio.c

index 78efcff..8ebc1ad 100644 (file)
@@ -1878,10 +1878,11 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre
        }
 
        /* set the period time minimum 1ms */
+       /* FIXME: high-speed mode allows 125us minimum period, but many parts
+        * in the current code assume the 1ms period.
+        */
        snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_PERIOD_TIME,
-                                    snd_usb_get_speed(subs->dev) == USB_SPEED_FULL ?
-                                    
-                                    1000 * MIN_PACKS_URB : 125 * MIN_PACKS_URB,
+                                    1000 * MIN_PACKS_URB,
                                     /*(nrpacks * MAX_URBS) * 1000*/ UINT_MAX);
 
        if (check_hw_params_convention(subs)) {