sysctl_check: drop table->procname checks
Denis Kirjanov [Wed, 23 Mar 2011 23:43:08 +0000 (16:43 -0700)]
Since the for loop checks for the table->procname drop useless
table->procname checks inside the loop body

Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

kernel/sysctl_check.c

index 10b90d8..3a01c3e 100644 (file)
@@ -111,11 +111,9 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table)
                const char *fail = NULL;
 
                if (table->parent) {
-                       if (table->procname && !table->parent->procname)
+                       if (!table->parent->procname)
                                set_fail(&fail, table, "Parent without procname");
                }
-               if (!table->procname)
-                       set_fail(&fail, table, "No procname");
                if (table->child) {
                        if (table->data)
                                set_fail(&fail, table, "Directory with data?");
@@ -144,7 +142,7 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table)
                                        set_fail(&fail, table, "No maxlen");
                        }
 #ifdef CONFIG_PROC_SYSCTL
-                       if (table->procname && !table->proc_handler)
+                       if (!table->proc_handler)
                                set_fail(&fail, table, "No proc_handler");
 #endif
 #if 0