ALSA: sound/ppc/powermac: remove undefined operations
Andreas Schwab [Sat, 11 Sep 2010 11:16:41 +0000 (13:16 +0200)]
Modifying an object twice without an intervening sequence point is
undefined.

Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

sound/ppc/tumbler.c

index 20afdf9..961d982 100644 (file)
@@ -785,7 +785,7 @@ static int snapper_set_capture_source(struct pmac_tumbler *mix)
        if (! mix->i2c.client)
                return -ENODEV;
        if (mix->capture_source)
-               mix->acs = mix->acs |= 2;
+               mix->acs |= 2;
        else
                mix->acs &= ~2;
        return i2c_smbus_write_byte_data(mix->i2c.client, TAS_REG_ACS, mix->acs);