Revert "cpufreq: interactive: avoid underflow on active time calculation"
Puneet Saxena [Thu, 22 Aug 2013 13:02:55 +0000 (18:02 +0530)]
Browser P0 Benchmarks such as Sunspider, Panning
are regressed drastically by switching to new interactive
governor.
The score didn’t meet with the score achieved via older governor
though tweaked new governor knobs extremely.
Hence reverting new governor and bugfixes on it.

This reverts commit 3e6b9d8fb4de1c4353af6e4f69dd00f84f9b98b9.

Bug 1352880

Change-Id: Ide505633dee53dcc3d799c875aca409f7f76d71f
Signed-off-by: Puneet Saxena <puneets@nvidia.com>
Reviewed-on: http://git-master/r/264926
Reviewed-by: Sachin Nikam <snikam@nvidia.com>

drivers/cpufreq/cpufreq_interactive.c

index 41eb437..7d34f54 100644 (file)
@@ -325,12 +325,7 @@ static u64 update_load(int cpu)
        now_idle = get_cpu_idle_time(cpu, &now);
        delta_idle = (unsigned int)(now_idle - pcpu->time_in_idle);
        delta_time = (unsigned int)(now - pcpu->time_in_idle_timestamp);
-
-       if (delta_time <= delta_idle)
-               active_time = 0;
-       else
-               active_time = delta_time - delta_idle;
-
+       active_time = delta_time - delta_idle;
        pcpu->cputime_speedadj += active_time * pcpu->policy->cur;
 
        pcpu->time_in_idle = now_idle;