Phonet: handle rtnetlink registration failure
remi.denis-courmont@nokia [Fri, 23 Jan 2009 03:00:28 +0000 (03:00 +0000)]
Signed-off-by: RĂ©mi Denis-Courmont <remi.denis-courmont@nokia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

include/net/phonet/pn_dev.h
net/phonet/pn_dev.c
net/phonet/pn_netlink.c

index 59ae628..4ba2aed 100644 (file)
@@ -38,7 +38,7 @@ struct phonet_device {
 
 int phonet_device_init(void);
 void phonet_device_exit(void);
-void phonet_netlink_register(void);
+int phonet_netlink_register(void);
 struct net_device *phonet_device_get(struct net *net);
 
 int phonet_address_add(struct net_device *dev, u8 addr);
index af49db0..fd41810 100644 (file)
@@ -190,9 +190,13 @@ static struct notifier_block phonet_device_notifier = {
 /* Initialize Phonet devices list */
 int __init phonet_device_init(void)
 {
+       int err;
+
        register_netdevice_notifier(&phonet_device_notifier);
-       phonet_netlink_register();
-       return 0;
+       err = phonet_netlink_register();
+       if (err)
+               phonet_device_exit();
+       return err;
 }
 
 void phonet_device_exit(void)
index 242fe8f..918a4f0 100644 (file)
@@ -160,9 +160,14 @@ out:
        return skb->len;
 }
 
-void __init phonet_netlink_register(void)
+int __init phonet_netlink_register(void)
 {
-       rtnl_register(PF_PHONET, RTM_NEWADDR, addr_doit, NULL);
-       rtnl_register(PF_PHONET, RTM_DELADDR, addr_doit, NULL);
-       rtnl_register(PF_PHONET, RTM_GETADDR, NULL, getaddr_dumpit);
+       int err = __rtnl_register(PF_PHONET, RTM_NEWADDR, addr_doit, NULL);
+       if (err)
+               return err;
+
+       /* Further __rtnl_register() cannot fail */
+       __rtnl_register(PF_PHONET, RTM_DELADDR, addr_doit, NULL);
+       __rtnl_register(PF_PHONET, RTM_GETADDR, NULL, getaddr_dumpit);
+       return 0;
 }