[XFS] don't call xfs_freesb from xfs_unmountfs
Christoph Hellwig [Wed, 13 Aug 2008 06:50:21 +0000 (16:50 +1000)]
xfs_readsb is called before xfs_mount so xfs_freesb should be called after
xfs_unmountfs, too. This means it now happens after a few things during
the of xfs_unmount which all have nothing to do with the superblock.

SGI-PV: 981498

SGI-Modid: xfs-linux-melb:xfs-kern:31835a

Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>

fs/xfs/linux-2.6/xfs_super.c
fs/xfs/xfs_mount.c

index 8fdb790..73c65f1 100644 (file)
@@ -1147,6 +1147,7 @@ xfs_fs_put_super(
        }
 
        xfs_unmountfs(mp);
+       xfs_freesb(mp);
        xfs_icsb_destroy_counters(mp);
        xfs_close_devices(mp);
        xfs_qmops_put(mp);
@@ -1803,7 +1804,7 @@ xfs_fs_fill_super(
        WARN_ON(error);
 
        xfs_unmountfs(mp);
-       goto out_free_fsname;
+       goto out_free_sb;
 }
 
 STATIC int
index 7f50272..4d41615 100644 (file)
@@ -1296,8 +1296,6 @@ xfs_unmountfs(
        xfs_unmountfs_wait(mp);                 /* wait for async bufs */
        xfs_log_unmount(mp);                    /* Done! No more fs ops. */
 
-       xfs_freesb(mp);
-
        /*
         * All inodes from this mount point should be freed.
         */