KEYS: Unlock tasklist when exiting early from keyctl_session_to_parent
Marc Dionne [Mon, 14 Sep 2009 11:46:23 +0000 (12:46 +0100)]
When we exit early from keyctl_session_to_parent because of permissions or
because the session keyring is the same as the parent, we need to unlock the
tasklist.

The missing unlock causes the system to hang completely when using
keyctl(KEYCTL_SESSION_TO_PARENT) with a keyring shared with the parent.

Signed-off-by: Marc Dionne <marc.c.dionne@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>

security/keys/keyctl.c

index 74c9685..60983f3 100644 (file)
@@ -1319,6 +1319,7 @@ long keyctl_session_to_parent(void)
 already_same:
        ret = 0;
 not_permitted:
+       write_unlock_irq(&tasklist_lock);
        put_cred(cred);
        return ret;