regulator: Report error codes for bulk operations
Mark Brown [Tue, 13 Oct 2009 12:06:49 +0000 (13:06 +0100)]
If we're going to log an error we may as well log what the error
code that we're failing on is.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>

drivers/regulator/core.c

index efe568d..9b43dab 100644 (file)
@@ -1885,9 +1885,9 @@ int regulator_bulk_get(struct device *dev, int num_consumers,
                consumers[i].consumer = regulator_get(dev,
                                                      consumers[i].supply);
                if (IS_ERR(consumers[i].consumer)) {
-                       dev_err(dev, "Failed to get supply '%s'\n",
-                               consumers[i].supply);
                        ret = PTR_ERR(consumers[i].consumer);
+                       dev_err(dev, "Failed to get supply '%s': %d\n",
+                               consumers[i].supply, ret);
                        consumers[i].consumer = NULL;
                        goto err;
                }
@@ -1930,7 +1930,7 @@ int regulator_bulk_enable(int num_consumers,
        return 0;
 
 err:
-       printk(KERN_ERR "Failed to enable %s\n", consumers[i].supply);
+       printk(KERN_ERR "Failed to enable %s: %d\n", consumers[i].supply, ret);
        for (i = 0; i < num_consumers; i++)
                regulator_disable(consumers[i].consumer);
 
@@ -1965,7 +1965,8 @@ int regulator_bulk_disable(int num_consumers,
        return 0;
 
 err:
-       printk(KERN_ERR "Failed to disable %s\n", consumers[i].supply);
+       printk(KERN_ERR "Failed to disable %s: %d\n", consumers[i].supply,
+              ret);
        for (i = 0; i < num_consumers; i++)
                regulator_enable(consumers[i].consumer);