cifs: fix compiler warning in CIFSSMBQAllEAs
Jeff Layton [Thu, 28 Jul 2011 16:48:26 +0000 (12:48 -0400)]
The recent fix to the above function causes this compiler warning to pop
on some gcc versions:

CC [M] fs/cifs/cifssmb.o
fs/cifs/cifssmb.c: In function ‘CIFSSMBQAllEAs’:
fs/cifs/cifssmb.c:5708: warning: ‘ea_name_len’ may be used uninitialized in
this function

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

fs/cifs/cifssmb.c

index 0580da1..187afe3 100644 (file)
@@ -5720,7 +5720,7 @@ CIFSSMBQAllEAs(const int xid, struct cifs_tcon *tcon,
        char *temp_ptr;
        char *end_of_smb;
        __u16 params, byte_count, data_offset;
-       unsigned int ea_name_len;
+       unsigned int ea_name_len = ea_name ? strlen(ea_name) : 0;
 
        cFYI(1, "In Query All EAs path %s", searchName);
 QAllEAsRetry:
@@ -5815,10 +5815,6 @@ QAllEAsRetry:
        list_len -= 4;
        temp_fea = ea_response_data->list;
        temp_ptr = (char *)temp_fea;
-
-       if (ea_name)
-               ea_name_len = strlen(ea_name);
-
        while (list_len > 0) {
                unsigned int name_len;
                __u16 value_len;