PM: Remove prev_state from struct dev_pm_info
Rafael J. Wysocki [Sun, 17 Jun 2007 17:48:06 +0000 (19:48 +0200)]
The prev_state member of struct dev_pm_info (defined in include/linux/pm.h) is
only used during a resume to check if the device's state before the suspend was
'off', in which case the device is not resumed.  However, in such cases the
decision whether or not to resume the device should be made on the driver level
and the resume callbacks from the device's bus and class should be executed
anyway (the may be needed for some things other than just powering on the
device).

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

drivers/base/power/resume.c
drivers/base/power/suspend.c
drivers/usb/core/hub.c
include/linux/pm.h

index 99679e7..0c96106 100644 (file)
@@ -88,8 +88,7 @@ void dpm_resume(void)
                list_move_tail(entry, &dpm_active);
 
                mutex_unlock(&dpm_list_mtx);
-               if (!dev->power.prev_state.event)
-                       resume_device(dev);
+               resume_device(dev);
                mutex_lock(&dpm_list_mtx);
                put_device(dev);
        }
index af2cedf..5178b0f 100644 (file)
@@ -71,8 +71,6 @@ int suspend_device(struct device * dev, pm_message_t state)
                        dev->parent->power.power_state.event);
        }
 
-       dev->power.prev_state = dev->power.power_state;
-
        if (dev->class && dev->class->suspend && !dev->power.power_state.event) {
                suspend_device_dbg(dev, state, "class ");
                error = dev->class->suspend(dev, state);
index 24f10a1..a9cf8b3 100644 (file)
@@ -1109,11 +1109,6 @@ void usb_root_hub_lost_power(struct usb_device *rhdev)
 
        dev_warn(&rhdev->dev, "root hub lost power or was reset\n");
 
-       /* Make sure no potential wakeup events get lost,
-        * by forcing the root hub to be resumed.
-        */
-       rhdev->dev.power.prev_state.event = PM_EVENT_ON;
-
        spin_lock_irqsave(&device_state_lock, flags);
        hub = hdev_to_hub(rhdev);
        for (port1 = 1; port1 <= rhdev->maxchild; ++port1) {
index 6e7f066..273781c 100644 (file)
@@ -267,7 +267,6 @@ struct dev_pm_info {
        unsigned                can_wakeup:1;
 #ifdef CONFIG_PM
        unsigned                should_wakeup:1;
-       pm_message_t            prev_state;
        struct list_head        entry;
 #endif
 };