[PATCH] mincore: fill in results properly
Nick Piggin [Wed, 14 Feb 2007 11:36:32 +0000 (12:36 +0100)]
Paper bag time. Thanks to Randy for noticing that I didn't actually assign
'present' to anything.

Unfortunately my original patch passed the few simple test cases I gave it,
purely by coincidence.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

mm/mincore.c

index 9780097..9c1d0a4 100644 (file)
@@ -125,6 +125,8 @@ static long do_mincore(unsigned long addr, unsigned char *vec, unsigned long pag
 #endif
                        }
                }
+
+               vec[i] = present;
        }
        pte_unmap_unlock(ptep-1, ptl);
 
@@ -135,6 +137,9 @@ none_mapped:
                pgoff = linear_page_index(vma, addr);
                for (i = 0; i < nr; i++, pgoff++)
                        vec[i] = mincore_page(vma->vm_file->f_mapping, pgoff);
+       } else {
+               for (i = 0; i < nr; i++)
+                       vec[i] = 0;
        }
 
        return nr;