regmap: Try cached read before checking if a hardware read is possible
Lars-Peter Clausen [Wed, 16 Nov 2011 15:28:19 +0000 (16:28 +0100)]
For some register format types we do not provide a parse_val so we can not do a
hardware read. But a cached read is still possible, so try to read from the
cache first, before checking whether a hardware read is possible. Otherwise the
cache becomes pretty useless for these register types.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
(cherry picked from commit 19254411db4e69d90958244c5017e7e4a38547b0)

Change-Id: Ibdcf86abfca530dfe40a425b1b172ab6b8114408
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Reviewed-on: http://git-master/r/87561

drivers/base/regmap/regmap.c

index 8f6c226..400f969 100644 (file)
@@ -434,15 +434,15 @@ static int _regmap_read(struct regmap *map, unsigned int reg,
 {
        int ret;
 
-       if (!map->format.parse_val)
-               return -EINVAL;
-
        if (!map->cache_bypass) {
                ret = regcache_read(map, reg, val);
                if (ret == 0)
                        return 0;
        }
 
+       if (!map->format.parse_val)
+               return -EINVAL;
+
        if (map->cache_only)
                return -EBUSY;