ASoC: dma.c: use devm_ functions
Julia Lawall [Thu, 29 Dec 2011 16:51:27 +0000 (17:51 +0100)]
The various devm_ functions allocate memory that is released when a driver
detaches.  This patch uses devm_kzalloc, devm_request_mem_region and
devm_ioremap for data that is allocated in the probe function of a platform
device and is only freed in the remove function.

Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

sound/soc/au1x/dma.c

index c4017bd..0a91b18 100644 (file)
@@ -325,27 +325,19 @@ static struct snd_soc_platform_driver alchemy_pcm_soc_platform = {
 static int __devinit alchemy_pcm_drvprobe(struct platform_device *pdev)
 {
        struct alchemy_pcm_ctx *ctx;
-       int ret;
 
-       ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
+       ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL);
        if (!ctx)
                return -ENOMEM;
 
        platform_set_drvdata(pdev, ctx);
 
-       ret = snd_soc_register_platform(&pdev->dev, &alchemy_pcm_soc_platform);
-       if (ret)
-               kfree(ctx);
-
-       return ret;
+       return snd_soc_register_platform(&pdev->dev, &alchemy_pcm_soc_platform);
 }
 
 static int __devexit alchemy_pcm_drvremove(struct platform_device *pdev)
 {
-       struct alchemy_pcm_ctx *ctx = platform_get_drvdata(pdev);
-
        snd_soc_unregister_platform(&pdev->dev);
-       kfree(ctx);
 
        return 0;
 }