USB: sisusbvga: no unnecessary GFP_ATOMIC
Oliver Neukum [Sat, 20 Feb 2010 00:40:54 +0000 (01:40 +0100)]
If a driver can wait on an event, it can also use GFP_KERNEL.

Signed-off-by: Oliver Neukum <neukum@b1-systems.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

drivers/usb/misc/sisusbvga/sisusb.c

index 3991655..aae95a0 100644 (file)
@@ -250,7 +250,7 @@ sisusb_bulkout_msg(struct sisusb_usb_data *sisusb, int index, unsigned int pipe,
        sisusb->urbstatus[index] |= SU_URB_BUSY;
 
        /* Submit URB */
-       retval = usb_submit_urb(urb, GFP_ATOMIC);
+       retval = usb_submit_urb(urb, GFP_KERNEL);
 
        /* If OK, and if timeout > 0, wait for completion */
        if ((retval == 0) && timeout) {
@@ -306,7 +306,7 @@ sisusb_bulkin_msg(struct sisusb_usb_data *sisusb, unsigned int pipe, void *data,
        urb->actual_length = 0;
 
        sisusb->completein = 0;
-       retval = usb_submit_urb(urb, GFP_ATOMIC);
+       retval = usb_submit_urb(urb, GFP_KERNEL);
        if (retval == 0) {
                wait_event_timeout(sisusb->wait_q, sisusb->completein, timeout);
                if (!sisusb->completein) {