checkpatch: add a "prefer __aligned" check
Joe Perches [Tue, 26 Jul 2011 00:13:24 +0000 (17:13 -0700)]
Prefer the use of __aligned(size) over __attribute__((__aligned___(size)))

Link: http://lkml.kernel.org/r/20110609094526.1571774c.akpm@linux-foundation.org

Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

scripts/checkpatch.pl

index b14f830..8f35f0e 100755 (executable)
@@ -2891,6 +2891,11 @@ sub process {
                        WARN("__packed is preferred over __attribute__((packed))\n" . $herecurr);
                }
 
+# Check for __attribute__ aligned, prefer __aligned
+               if ($line =~ /\b__attribute__\s*\(\s*\(.*aligned/) {
+                       WARN("__aligned(size) is preferred over __attribute__((aligned(size)))\n" . $herecurr);
+               }
+
 # check for sizeof(&)
                if ($line =~ /\bsizeof\s*\(\s*\&/) {
                        WARN("sizeof(& should be avoided\n" . $herecurr);