[PATCH] fix idiocy in asd_init_lseq_mdp()
Al Viro [Mon, 25 Sep 2006 01:57:22 +0000 (02:57 +0100)]
To whoever had written that code:

 a) priority of >> is higher than that of &
 b) priority of typecast is higher than that of any binary operator
 c) learn the fscking C

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

drivers/scsi/aic94xx/aic94xx_seq.c

index d9b6da5..56e4b3b 100644 (file)
@@ -764,7 +764,7 @@ static void asd_init_lseq_mdp(struct asd_ha_struct *asd_ha,  int lseq)
        asd_write_reg_word(asd_ha, LmSEQ_FIRST_INV_SCB_SITE(lseq),
                           (u16)last_scb_site_no+1);
        asd_write_reg_word(asd_ha, LmSEQ_INTEN_SAVE(lseq),
-                           (u16) LmM0INTEN_MASK & 0xFFFF0000 >> 16);
+                           (u16) ((LmM0INTEN_MASK & 0xFFFF0000) >> 16));
        asd_write_reg_word(asd_ha, LmSEQ_INTEN_SAVE(lseq) + 2,
                            (u16) LmM0INTEN_MASK & 0xFFFF);
        asd_write_reg_byte(asd_ha, LmSEQ_LINK_RST_FRM_LEN(lseq), 0);