[PATCH] Remove redundant check from autofs4_put_super
Dave Jones [Mon, 27 Mar 2006 09:14:57 +0000 (01:14 -0800)]
We have to have a valid sbi here, or we'd have oopsed already.  (There's a
dereference of sbi->catatonic a few lines above)

Coverity #740

Signed-off-by: Dave Jones <davej@redhat.com>
Cc: Ian Kent <raven@themaw.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

fs/autofs4/inode.c

index 9438889..4eddee4 100644 (file)
@@ -157,8 +157,7 @@ static void autofs4_put_super(struct super_block *sb)
                autofs4_catatonic_mode(sbi); /* Free wait queues, close pipe */
 
        /* Clean up and release dangling references */
-       if (sbi)
-               autofs4_force_release(sbi);
+       autofs4_force_release(sbi);
 
        kfree(sbi);