mfd: Return proper error if tps65090 regmap_init_i2c fails
Axel Lin [Wed, 25 Apr 2012 01:30:36 +0000 (09:30 +0800)]
Return proper error instead of 0 if regmap_init_i2c fails.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Venu Byravarasu <vbyravarasu@nvidia.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
(Cherrypicked from mainline
b683a0a675560307ebc458cf9044d98d27820b7c)

Change-Id: I2643a80e320664723d0fbb91b22120ec8d82a7df
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Reviewed-on: http://git-master/r/120370

drivers/mfd/tps65090.c

index 6dc4c34..d994087 100644 (file)
@@ -297,10 +297,10 @@ static int __devinit tps65090_i2c_probe(struct i2c_client *client,
        tps65090->rmap = regmap_init_i2c(tps65090->client,
                &tps65090_regmap_config);
        if (IS_ERR(tps65090->rmap)) {
-               dev_err(&client->dev, "regmap_init failed with err: %ld\n",
-                       PTR_ERR(tps65090->rmap));
+               ret = PTR_ERR(tps65090->rmap);
+               dev_err(&client->dev, "regmap_init failed with err: %d\n", ret);
                goto err_irq_exit;
-       };
+       }
 
        ret = mfd_add_devices(tps65090->dev, -1, tps65090s,
                ARRAY_SIZE(tps65090s), NULL, 0);