the overdue removal of the mount/umount uevents
Adrian Bunk [Fri, 6 Apr 2007 10:21:45 +0000 (12:21 +0200)]
This patch contains the overdue removal of the mount/umount uevents.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Documentation/feature-removal-schedule.txt
fs/super.c
include/linux/kobject.h
lib/kobject_uevent.c

index 6da6636..ec0b484 100644 (file)
@@ -134,15 +134,6 @@ Who:       Arjan van de Ven <arjan@linux.intel.com>
 
 ---------------------------
 
-What:  mount/umount uevents
-When:  February 2007
-Why:   These events are not correct, and do not properly let userspace know
-       when a file system has been mounted or unmounted.  Userspace should
-       poll the /proc/mounts file instead to detect this properly.
-Who:   Greg Kroah-Hartman <gregkh@suse.de>
-
----------------------------
-
 What:  USB driver API moves to EXPORT_SYMBOL_GPL
 When:  February 2008
 Files: include/linux/usb.h, drivers/usb/core/driver.c
index 60b1e50..8341e4e 100644 (file)
@@ -725,16 +725,6 @@ static int test_bdev_super(struct super_block *s, void *data)
        return (void *)s->s_bdev == data;
 }
 
-static void bdev_uevent(struct block_device *bdev, enum kobject_action action)
-{
-       if (bdev->bd_disk) {
-               if (bdev->bd_part)
-                       kobject_uevent(&bdev->bd_part->kobj, action);
-               else
-                       kobject_uevent(&bdev->bd_disk->kobj, action);
-       }
-}
-
 int get_sb_bdev(struct file_system_type *fs_type,
        int flags, const char *dev_name, void *data,
        int (*fill_super)(struct super_block *, void *, int),
@@ -782,7 +772,6 @@ int get_sb_bdev(struct file_system_type *fs_type,
                }
 
                s->s_flags |= MS_ACTIVE;
-               bdev_uevent(bdev, KOBJ_MOUNT);
        }
 
        return simple_set_mnt(mnt, s);
@@ -801,7 +790,6 @@ void kill_block_super(struct super_block *sb)
 {
        struct block_device *bdev = sb->s_bdev;
 
-       bdev_uevent(bdev, KOBJ_UMOUNT);
        generic_shutdown_super(sb);
        sync_blockdev(bdev);
        close_bdev_excl(bdev);
index a659a97..eb0e63e 100644 (file)
@@ -42,11 +42,9 @@ enum kobject_action {
        KOBJ_ADD        = (__force kobject_action_t) 0x01,      /* exclusive to core */
        KOBJ_REMOVE     = (__force kobject_action_t) 0x02,      /* exclusive to core */
        KOBJ_CHANGE     = (__force kobject_action_t) 0x03,      /* device state change */
-       KOBJ_MOUNT      = (__force kobject_action_t) 0x04,      /* mount event for block devices (broken) */
-       KOBJ_UMOUNT     = (__force kobject_action_t) 0x05,      /* umount event for block devices (broken) */
-       KOBJ_OFFLINE    = (__force kobject_action_t) 0x06,      /* device offline */
-       KOBJ_ONLINE     = (__force kobject_action_t) 0x07,      /* device online */
-       KOBJ_MOVE       = (__force kobject_action_t) 0x08,      /* device move */
+       KOBJ_OFFLINE    = (__force kobject_action_t) 0x04,      /* device offline */
+       KOBJ_ONLINE     = (__force kobject_action_t) 0x05,      /* device online */
+       KOBJ_MOVE       = (__force kobject_action_t) 0x06,      /* device move */
 };
 
 struct kobject {
index d9a3510..12e311d 100644 (file)
@@ -42,10 +42,6 @@ static char *action_to_string(enum kobject_action action)
                return "remove";
        case KOBJ_CHANGE:
                return "change";
-       case KOBJ_MOUNT:
-               return "mount";
-       case KOBJ_UMOUNT:
-               return "umount";
        case KOBJ_OFFLINE:
                return "offline";
        case KOBJ_ONLINE: