ARM: CPU hotplug: fix abuse of irqdesc->node
Russell King [Thu, 21 Jul 2011 13:51:13 +0000 (14:51 +0100)]
irqdesc's node member is supposed to mark the numa node number for the
interrupt.  Our use of it is non-standard.  Remove this, replacing the
functionality with a test of the affinity mask.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

arch/arm/common/gic.c
arch/arm/kernel/irq.c

index 4ddd0a6..635d985 100644 (file)
@@ -189,7 +189,6 @@ static int gic_set_affinity(struct irq_data *d, const struct cpumask *mask_val,
        bit = 1 << (cpu + shift);
 
        spin_lock(&irq_controller_lock);
-       d->node = cpu;
        val = readl_relaxed(reg) & ~mask;
        writel_relaxed(val | bit, reg);
        spin_unlock(&irq_controller_lock);
index 83bbad0..d7aa5c9 100644 (file)
@@ -166,15 +166,9 @@ void migrate_irqs(void)
                bool affinity_broken = false;
 
                raw_spin_lock(&desc->lock);
-               do {
-                       if (desc->action == NULL)
-                               break;
-
-                       if (d->node != cpu)
-                               break;
-
+               if (desc->action != NULL &&
+                   cpumask_test_cpu(smp_processor_id(), d->affinity))
                        affinity_broken = migrate_one_irq(d);
-               } while (0);
                raw_spin_unlock(&desc->lock);
 
                if (affinity_broken && printk_ratelimit())