V4L/DVB (11079): au0828: fix panic on disconnect if analog initialization failed
Devin Heitmueller [Wed, 11 Mar 2009 06:01:02 +0000 (03:01 -0300)]
If the analog initialization failed to create the video device, we never
actually add the entry to the au0828_devlist.  Therefore a panic occurs when
unregistering the analog subsystem.

Make it so we only remove the entry from the list if we added it to the list
in the first place.

Signed-off-by: Devin Heitmueller <dheitmueller@linuxtv.org>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

drivers/media/video/au0828/au0828-video.c

index 4c77aeb..6abdd8b 100644 (file)
@@ -700,9 +700,10 @@ void au0828_analog_unregister(struct au0828_dev *dev)
        dprintk(1, "au0828_release_resources called\n");
        mutex_lock(&au0828_sysfs_lock);
 
-       list_del(&dev->au0828list);
-       if (dev->vdev)
+       if (dev->vdev) {
+               list_del(&dev->au0828list);
                video_unregister_device(dev->vdev);
+       }
        if (dev->vbi_dev)
                video_unregister_device(dev->vbi_dev);