ASoC: wm8711: fix a memory leak if another WM8711 is registered
Axel Lin [Fri, 23 Jul 2010 05:53:47 +0000 (05:53 +0000)]
wm8711 is allocated in either wm8711_spi_probe() or wm8711_i2c_probe() but is
not freed if wm8711_register() return -EINVAL(if another ad1836 is registered).

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

sound/soc/codecs/wm8711.c

index effb14e..e2dba07 100644 (file)
@@ -439,7 +439,8 @@ static int wm8711_register(struct wm8711_priv *wm8711,
 
        if (wm8711_codec) {
                dev_err(codec->dev, "Another WM8711 is registered\n");
-               return -EINVAL;
+               ret = -EINVAL;
+               goto err;
        }
 
        mutex_init(&codec->mutex);