regulator: rc5t583: Fix off-by-one valid range checking for selector
Axel Lin [Wed, 4 Apr 2012 14:38:09 +0000 (22:38 +0800)]
The valid selector should be 0 ... nsteps-1.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
(cherry picked from commit 9cc7a453b637d8c1f628f9873204ff55d7aa664c)

Change-Id: Ie1a39883036de3b2945d35854e0a16c46d2a9db2
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Reviewed-on: http://git-master/r/105882
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Bitan Biswas <bbiswas@nvidia.com>

drivers/regulator/rc5t583-regulator.c

index 27ef2fb..a6f4b5e 100644 (file)
@@ -131,7 +131,7 @@ static int rc5t583_set_voltage_sel(struct regulator_dev *rdev,
        struct rc5t583_regulator *reg = rdev_get_drvdata(rdev);
        struct rc5t583_regulator_info *ri = reg->reg_info;
        int ret;
-       if (selector > ri->nsteps) {
+       if (selector >= ri->nsteps) {
                dev_err(&rdev->dev, "Invalid selector 0x%02x\n", selector);
                return -EINVAL;
        }