hamradio: Resolve memory leak due to missing firmware release in add_mcs()
Jesper Juhl [Thu, 6 Jan 2011 10:50:29 +0000 (10:50 +0000)]
Failure to release_firmware() in drivers/net/hamradio/yam.c::add_mcs()
causes memory leak.
This patch should fix it.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

drivers/net/hamradio/yam.c

index 4e7d1d0..7d9ced0 100644 (file)
@@ -396,7 +396,7 @@ static unsigned char *add_mcs(unsigned char *bits, int bitrate,
        while (p) {
                if (p->bitrate == bitrate) {
                        memcpy(p->bits, bits, YAM_FPGA_SIZE);
-                       return p->bits;
+                       goto out;
                }
                p = p->next;
        }
@@ -411,7 +411,7 @@ static unsigned char *add_mcs(unsigned char *bits, int bitrate,
        p->bitrate = bitrate;
        p->next = yam_data;
        yam_data = p;
-
+ out:
        release_firmware(fw);
        return p->bits;
 }