epoll: Fix user space breakage related to EPOLLWAKEUP
Rafael J. Wysocki [Mon, 21 May 2012 19:20:48 +0000 (21:20 +0200)]
Commit 4d7e30d (epoll: Add a flag, EPOLLWAKEUP, to prevent
suspend while epoll events are ready) caused some applications to
malfunction, because they set the bit corresponding to the new
EPOLLWAKEUP flag in their eventpoll flags and they don't have the
new CAP_EPOLLWAKEUP capability.

To prevent that from happening, change epoll_ctl() to clear
EPOLLWAKEUP in epds.events if the caller doesn't have the
CAP_EPOLLWAKEUP capability instead of failing and returning an
error code, which allows the affected applications to function
normally.

Reported-and-tested-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

fs/eventpoll.c

index 2cf0f21..079d1be 100644 (file)
@@ -1711,7 +1711,7 @@ SYSCALL_DEFINE4(epoll_ctl, int, epfd, int, op, int, fd,
 
        /* Check if EPOLLWAKEUP is allowed */
        if ((epds.events & EPOLLWAKEUP) && !capable(CAP_EPOLLWAKEUP))
-               goto error_tgt_fput;
+               epds.events &= ~EPOLLWAKEUP;
 
        /*
         * We have to check that the file structure underneath the file descriptor