[SCSI] qla2xxx: Correction to sysfs edc interface.
Joe Carnuccio [Tue, 16 Aug 2011 18:31:51 +0000 (11:31 -0700)]
Corrects the return value for the cases where read/write edc fails;
this prevents sysfs from retrying the operation until forever.

Corrects the printk width specifier for the first byte of buf.

Signed-off-by: Joe Carnuccio <joe.carnuccio@qlogic.com>
Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

drivers/scsi/qla2xxx/qla_attr.c

index df0002f..c9c42a6 100644 (file)
@@ -668,9 +668,9 @@ qla2x00_sysfs_write_edc(struct file *filp, struct kobject *kobj,
            dev, adr, len, opt);
        if (rval != QLA_SUCCESS) {
                ql_log(ql_log_warn, vha, 0x7074,
-                   "Unable to write EDC (%x) %02x:%04x:%02x:%02x\n",
+                   "Unable to write EDC (%x) %02x:%04x:%02x:%02hhx\n",
                    rval, dev, adr, opt, len, buf[8]);
-               return 0;
+               return -EINVAL;
        }
 
        return count;
@@ -727,7 +727,7 @@ qla2x00_sysfs_write_edc_status(struct file *filp, struct kobject *kobj,
                ql_log(ql_log_info, vha, 0x7075,
                    "Unable to write EDC status (%x) %02x:%04x:%02x.\n",
                    rval, dev, adr, opt, len);
-               return 0;
+               return -EINVAL;
        }
 
        ha->edc_data_len = len;