[ALSA] pcsp: locking fix
Stas Sergeev [Wed, 12 Mar 2008 12:12:15 +0000 (13:12 +0100)]
pcsp: locking fix.

Signed-off-by: Stas Sergeev <stsp@aknet.ru>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

sound/drivers/pcsp/pcsp.c
sound/drivers/pcsp/pcsp_lib.c

index 547005c..ac57e87 100644 (file)
@@ -191,11 +191,10 @@ static int __devexit pcsp_remove(struct platform_device *dev)
 
 static void pcsp_stop_beep(struct snd_pcsp *chip)
 {
-       unsigned long flags;
-       spin_lock_irqsave(&chip->substream_lock, flags);
+       spin_lock_irq(&chip->substream_lock);
        if (!chip->playback_substream)
                pcspkr_stop_sound();
-       spin_unlock_irqrestore(&chip->substream_lock, flags);
+       spin_unlock_irq(&chip->substream_lock);
 }
 
 static int pcsp_suspend(struct platform_device *dev, pm_message_t state)
index a302756..54253e9 100644 (file)
@@ -305,7 +305,9 @@ static int snd_pcsp_playback_open(struct snd_pcm_substream *substream)
                return -EBUSY;
        }
        runtime->hw = snd_pcsp_playback;
+       spin_lock_irq(&chip->substream_lock);
        chip->playback_substream = substream;
+       spin_unlock_irq(&chip->substream_lock);
        return 0;
 }