edd: fix possible memory leak in edd_init() error path
Axel Lin [Tue, 10 Aug 2010 00:20:56 +0000 (17:20 -0700)]
The error may happen at any iteration of the for loop, this patch properly
unregisters already registed edd_devices in error path.

[akpm@linux-foundation.org: remove unneeded NULL test]
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

drivers/firmware/edd.c

index 110e24e..f287fe7 100644 (file)
@@ -744,7 +744,7 @@ static inline int edd_num_devices(void)
 static int __init
 edd_init(void)
 {
-       unsigned int i;
+       int i;
        int rc=0;
        struct edd_device *edev;
 
@@ -760,21 +760,27 @@ edd_init(void)
        if (!edd_kset)
                return -ENOMEM;
 
-       for (i = 0; i < edd_num_devices() && !rc; i++) {
+       for (i = 0; i < edd_num_devices(); i++) {
                edev = kzalloc(sizeof (*edev), GFP_KERNEL);
-               if (!edev)
-                       return -ENOMEM;
+               if (!edev) {
+                       rc = -ENOMEM;
+                       goto out;
+               }
 
                rc = edd_device_register(edev, i);
                if (rc) {
                        kfree(edev);
-                       break;
+                       goto out;
                }
                edd_devices[i] = edev;
        }
 
-       if (rc)
-               kset_unregister(edd_kset);
+       return 0;
+
+out:
+       while (--i >= 0)
+               edd_device_unregister(edd_devices[i]);
+       kset_unregister(edd_kset);
        return rc;
 }