KVM: Update intr delivery func to accept unsigned long* bitmap
Sheng Yang [Wed, 11 Feb 2009 08:03:39 +0000 (16:03 +0800)]
Would be used with bit ops, and would be easily extended if KVM_MAX_VCPUS is
increased.

Signed-off-by: Sheng Yang <sheng@linux.intel.com>
Signed-off-by: Avi Kivity <avi@redhat.com>

arch/x86/kvm/lapic.c
virt/kvm/ioapic.h
virt/kvm/irq_comm.c

index f0b67f2..6aa8d20 100644 (file)
@@ -409,7 +409,7 @@ static int __apic_accept_irq(struct kvm_lapic *apic, int delivery_mode,
 }
 
 static struct kvm_lapic *kvm_apic_round_robin(struct kvm *kvm, u8 vector,
-                                      unsigned long bitmap)
+                                      unsigned long *bitmap)
 {
        int last;
        int next;
@@ -421,7 +421,7 @@ static struct kvm_lapic *kvm_apic_round_robin(struct kvm *kvm, u8 vector,
        do {
                if (++next == KVM_MAX_VCPUS)
                        next = 0;
-               if (kvm->vcpus[next] == NULL || !test_bit(next, &bitmap))
+               if (kvm->vcpus[next] == NULL || !test_bit(next, bitmap))
                        continue;
                apic = kvm->vcpus[next]->arch.apic;
                if (apic && apic_enabled(apic))
@@ -437,7 +437,7 @@ static struct kvm_lapic *kvm_apic_round_robin(struct kvm *kvm, u8 vector,
 }
 
 struct kvm_vcpu *kvm_get_lowest_prio_vcpu(struct kvm *kvm, u8 vector,
-               unsigned long bitmap)
+               unsigned long *bitmap)
 {
        struct kvm_lapic *apic;
 
@@ -508,7 +508,7 @@ static void apic_send_ipi(struct kvm_lapic *apic)
        }
 
        if (delivery_mode == APIC_DM_LOWEST) {
-               target = kvm_get_lowest_prio_vcpu(vcpu->kvm, vector, lpr_map);
+               target = kvm_get_lowest_prio_vcpu(vcpu->kvm, vector, &lpr_map);
                if (target != NULL)
                        __apic_accept_irq(target->arch.apic, delivery_mode,
                                          vector, level, trig_mode);
index f395798..7275f87 100644 (file)
@@ -65,7 +65,7 @@ static inline struct kvm_ioapic *ioapic_irqchip(struct kvm *kvm)
 }
 
 struct kvm_vcpu *kvm_get_lowest_prio_vcpu(struct kvm *kvm, u8 vector,
-                                      unsigned long bitmap);
+                                      unsigned long *bitmap);
 void kvm_ioapic_update_eoi(struct kvm *kvm, int vector, int trigger_mode);
 int kvm_ioapic_init(struct kvm *kvm);
 int kvm_ioapic_set_irq(struct kvm_ioapic *ioapic, int irq, int level);
index e8ff89c..d4421cd 100644 (file)
@@ -55,7 +55,7 @@ void kvm_get_intr_delivery_bitmask(struct kvm_ioapic *ioapic,
        switch (entry->fields.delivery_mode) {
        case IOAPIC_LOWEST_PRIORITY:
                vcpu = kvm_get_lowest_prio_vcpu(ioapic->kvm,
-                               entry->fields.vector, *deliver_bitmask);
+                               entry->fields.vector, deliver_bitmask);
                *deliver_bitmask = 1 << vcpu->vcpu_id;
                break;
        case IOAPIC_FIXED: