Input: put ledstate in the keyboard notifier
Karl Dahlke [Tue, 15 Apr 2008 05:30:32 +0000 (01:30 -0400)]
Led state should be part of the key event, like shiftstate, and not
grabbed asynchronously after the fact.

[samuel.thibault@ens-lyon.org: various fixes]

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

drivers/char/keyboard.c
include/linux/keyboard.h

index 4dbd342..59608e3 100644 (file)
@@ -1237,6 +1237,7 @@ static void kbd_keycode(unsigned int keycode, int down, int hw_raw)
        }
 
        param.shift = shift_final = (shift_state | kbd->slockstate) ^ kbd->lockstate;
+       param.ledstate = kbd->ledflagstate;
        key_map = key_maps[shift_final];
 
        if (atomic_notifier_call_chain(&keyboard_notifier_list, KBD_KEYCODE, &param) == NOTIFY_STOP || !key_map) {
@@ -1285,6 +1286,7 @@ static void kbd_keycode(unsigned int keycode, int down, int hw_raw)
 
        (*k_handler[type])(vc, keysym & 0xff, !down);
 
+       param.ledstate = kbd->ledflagstate;
        atomic_notifier_call_chain(&keyboard_notifier_list, KBD_POST_KEYSYM, &param);
 
        if (type != KT_SLOCK)
index 65c2d70..a3c984d 100644 (file)
@@ -33,6 +33,7 @@ struct keyboard_notifier_param {
        struct vc_data *vc;     /* VC on which the keyboard press was done */
        int down;               /* Pressure of the key? */
        int shift;              /* Current shift mask */
+       int ledstate;           /* Current led state */
        unsigned int value;     /* keycode, unicode value or keysym */
 };