PCI hotplug: shpchp: Removed check for hotplug of display devices
Praveen Kalamegham [Thu, 20 May 2010 17:15:01 +0000 (12:15 -0500)]
Removed check to prevent hotplug of display devices within shpchp.
Originally this was thought to have been required within the PCI
Hotplug specification for some legacy devices.  However there is
no such requirement in the most recent revision. The check prevents
hotplug of not only display devices but also computational GPUs
which require serviceability.

Signed-off-by: Praveen Kalamegham <praveen@nextio.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

drivers/pci/hotplug/shpchp_pci.c

index 8c3d321..a2ccfcd 100644 (file)
@@ -60,12 +60,6 @@ int __ref shpchp_configure_device(struct slot *p_slot)
                dev = pci_get_slot(parent, PCI_DEVFN(p_slot->device, fn));
                if (!dev)
                        continue;
-               if ((dev->class >> 16) == PCI_BASE_CLASS_DISPLAY) {
-                       ctrl_err(ctrl, "Cannot hot-add display device %s\n",
-                                pci_name(dev));
-                       pci_dev_put(dev);
-                       continue;
-               }
                if ((dev->hdr_type == PCI_HEADER_TYPE_BRIDGE) ||
                                (dev->hdr_type == PCI_HEADER_TYPE_CARDBUS)) {
                        /* Find an unused bus number for the new bridge */
@@ -114,17 +108,11 @@ int shpchp_unconfigure_device(struct slot *p_slot)
        ctrl_dbg(ctrl, "%s: domain:bus:dev = %04x:%02x:%02x\n",
                 __func__, pci_domain_nr(parent), p_slot->bus, p_slot->device);
 
-       for (j=0; j<8 ; j++) {
-               struct pci_dev* temp = pci_get_slot(parent,
+       for (j = 0; j < 8 ; j++) {
+               struct pci_dev *temp = pci_get_slot(parent,
                                (p_slot->device << 3) | j);
                if (!temp)
                        continue;
-               if ((temp->class >> 16) == PCI_BASE_CLASS_DISPLAY) {
-                       ctrl_err(ctrl, "Cannot remove display device %s\n",
-                                pci_name(temp));
-                       pci_dev_put(temp);
-                       continue;
-               }
                if (temp->hdr_type == PCI_HEADER_TYPE_BRIDGE) {
                        pci_read_config_byte(temp, PCI_BRIDGE_CONTROL, &bctl);
                        if (bctl & PCI_BRIDGE_CTL_VGA) {
@@ -132,7 +120,8 @@ int shpchp_unconfigure_device(struct slot *p_slot)
                                         "Cannot remove display device %s\n",
                                         pci_name(temp));
                                pci_dev_put(temp);
-                               continue;
+                               rc = -EINVAL;
+                               break;
                        }
                }
                pci_remove_bus_device(temp);