usb: cdc-acm: enable need_remote_wakeup by default
Venu Byravarasu [Wed, 17 Oct 2012 12:58:10 +0000 (17:58 +0530)]
This was disabled in a previous commit as it was thought that the
flag prevented autosuspend from working. However autosuspend will
succeed as long as the modem enumerates with the Remote Wakeup bit
set in the bmAttributes field of the Configuration descriptor.

Bug 1058567

Change-Id: I79b35f8edec4511da19bcc3f761d666d388c655d
Signed-off-by: Neil Patel <neilp@nvidia.com>
Reviewed-on: http://git-master/r/147062
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Steve Lin <stlin@nvidia.com>

drivers/usb/class/cdc-acm.c

index 60188df..4e33418 100644 (file)
@@ -573,7 +573,7 @@ static int acm_port_activate(struct tty_port *port, struct tty_struct *tty)
         * memory is really nasty...
         */
        set_bit(TTY_NO_WRITE_SPLIT, &tty->flags);
-       acm->control->needs_remote_wakeup = 0;
+       acm->control->needs_remote_wakeup = 1;
 
        if (acm_submit_read_urbs(acm, GFP_KERNEL))
                goto error_submit_urb;