USB: Remove BKL from usbdev_open()
Oliver Neukum [Wed, 13 Jan 2010 14:31:48 +0000 (15:31 +0100)]
Locking had long been changed making BKL redundant.
Simply remove it.

Signed-off-by: Oliver Neukum <oliver@neukum.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

drivers/usb/core/devio.c

index 825e0ab..6e73150 100644 (file)
@@ -653,8 +653,6 @@ static int usbdev_open(struct inode *inode, struct file *file)
        const struct cred *cred = current_cred();
        int ret;
 
-       lock_kernel();
-
        ret = -ENOMEM;
        ps = kmalloc(sizeof(struct dev_state), GFP_KERNEL);
        if (!ps)
@@ -713,7 +711,6 @@ static int usbdev_open(struct inode *inode, struct file *file)
        usb_unlock_device(dev);
        snoop(&dev->dev, "opened by process %d: %s\n", task_pid_nr(current),
                        current->comm);
-       unlock_kernel();
        return ret;
 
  out_unlock_device:
@@ -721,7 +718,6 @@ static int usbdev_open(struct inode *inode, struct file *file)
        usb_put_dev(dev);
  out_free_ps:
        kfree(ps);
-       unlock_kernel();
        return ret;
 }