crypto: cryptd - Fix uninitialized return value
Steffen Klassert [Wed, 15 Jul 2009 08:51:04 +0000 (16:51 +0800)]
If cryptd_alloc_instance() fails, the return value is uninitialized.
This patch fixes this by setting the return value.

Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

crypto/cryptd.c

index 5dabb7d..fbd26f9 100644 (file)
@@ -303,6 +303,7 @@ static int cryptd_create_blkcipher(struct crypto_template *tmpl,
                return PTR_ERR(alg);
 
        inst = cryptd_alloc_instance(alg, 0, sizeof(*ctx));
+       err = PTR_ERR(inst);
        if (IS_ERR(inst))
                goto out_put_alg;
 
@@ -522,6 +523,7 @@ static int cryptd_create_hash(struct crypto_template *tmpl, struct rtattr **tb,
        alg = &salg->base;
        inst = cryptd_alloc_instance(alg, ahash_instance_headroom(),
                                     sizeof(*ctx));
+       err = PTR_ERR(inst);
        if (IS_ERR(inst))
                goto out_put_alg;